Skip to content

bpo-40013: Added documentation to csv.DictReader restval#19099

Merged
tirkarthi merged 1 commit into
python:masterfrom
juhanakristian:master
Mar 24, 2020
Merged

bpo-40013: Added documentation to csv.DictReader restval#19099
tirkarthi merged 1 commit into
python:masterfrom
juhanakristian:master

Conversation

@juhanakristian

@juhanakristian juhanakristian commented Mar 21, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Mar 21, 2020
aeros
aeros approved these changes Mar 22, 2020
View reviewed changes

@aeros aeros left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @brandfilt, LGTM. The docs for DictReader should definitely explain the purpose of the restval parameter.

tirkarthi
tirkarthi approved these changes Mar 24, 2020
View reviewed changes

@tirkarthi tirkarthi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@tirkarthi tirkarthi merged commit 4b3252c into python:master Mar 24, 2020
@miss-islington

miss-islington commented Mar 24, 2020

Copy link
Copy Markdown
Contributor

Thanks @brandfilt for the PR, and @tirkarthi for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 24, 2020
@juhanakristian @miss-islington
bpo-40013: Clarify documentation of restval in csv.DictReader (python…
67e1b26 
…GH-19099)

(cherry picked from commit 4b3252c)

Co-authored-by: Juhana Jauhiainen <juhana.jauhiainen@gmail.com>
@bedevere-bot

bedevere-bot commented Mar 24, 2020

Copy link
Copy Markdown

GH-19141 is a backport of this pull request to the 3.8 branch.

@bedevere-bot

bedevere-bot commented Mar 24, 2020

Copy link
Copy Markdown

GH-19142 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 24, 2020
@juhanakristian @miss-islington
bpo-40013: Clarify documentation of restval in csv.DictReader (python…
c7d03be 
…GH-19099)

(cherry picked from commit 4b3252c)

Co-authored-by: Juhana Jauhiainen <juhana.jauhiainen@gmail.com>
tirkarthi pushed a commit that referenced this pull request Mar 25, 2020
@miss-islington @juhanakristian
bpo-40013: Clarify documentation of restval in csv.DictReader (GH-19099…
2227c1a 
…) (GH-19141)

(cherry picked from commit 4b3252c)


Co-authored-by: Juhana Jauhiainen <juhana.jauhiainen@gmail.com>
tirkarthi pushed a commit that referenced this pull request Mar 25, 2020
@miss-islington @juhanakristian
bpo-40013: Clarify documentation of restval in csv.DictReader (GH-19099…
e5527f0 
…) (GH-19142)

(cherry picked from commit 4b3252c)


Co-authored-by: Juhana Jauhiainen <juhana.jauhiainen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tirkarthi tirkarthi tirkarthi approved these changes
+1 more reviewer
@aeros aeros aeros approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@juhanakristian @miss-islington @bedevere-bot @tirkarthi @aeros @the-knights-who-say-ni